+ <% all_questions_with_errors = all_questions_affected_by_errors(@log) %>
<% remove_other_page_errors(@log, @page) %>
<%= f.govuk_error_summary %>
@@ -69,6 +70,17 @@
<%= f.hidden_field :page, value: @page.id %>
<%= f.hidden_field :interruption_page_id, value: @interruption_page_id %>
<%= f.hidden_field :interruption_page_referrer_type, value: @interruption_page_referrer_type %>
+ <%= f.hidden_field :related_question_ids, value: @related_question_ids %>
+ <%= f.hidden_field :original_page_id, value: @original_page_id %>
+ <% if @check_errors %>
+ <%= f.hidden_field :check_errors, value: @check_errors %>
+ <% end %>
+
+ <% if all_questions_with_errors.count > 1 %>
+
+ <%= f.submit "See all related answers", name: "check_errors", class: "govuk-body govuk-link submit-button-link" %>
+
+ <% end %>
<% if !@page.interruption_screen? %>
diff --git a/config/routes.rb b/config/routes.rb
index e8932ea45..a6de59a65 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -214,6 +214,8 @@ Rails.application.routes.draw do
get "delete-confirmation", to: "lettings_logs#delete_confirmation"
get "duplicate-logs", to: "duplicate_logs#show"
get "delete-duplicates", to: "duplicate_logs#delete_duplicates"
+ post "confirm-clear-answer", to: "check_errors#confirm_clear_answer"
+ post "confirm-clear-all-answers", to: "check_errors#confirm_clear_all_answers"
collection do
get "csv-download", to: "lettings_logs#download_csv"
@@ -284,6 +286,8 @@ Rails.application.routes.draw do
get "delete-confirmation", to: "sales_logs#delete_confirmation"
get "duplicate-logs", to: "duplicate_logs#show"
get "delete-duplicates", to: "duplicate_logs#delete_duplicates"
+ post "confirm-clear-answer", to: "check_errors#confirm_clear_answer"
+ post "confirm-clear-all-answers", to: "check_errors#confirm_clear_all_answers"
collection do
get "csv-download", to: "sales_logs#download_csv"
diff --git a/spec/features/form/page_routing_spec.rb b/spec/features/form/page_routing_spec.rb
index 8ee63de03..42a2c25fb 100644
--- a/spec/features/form/page_routing_spec.rb
+++ b/spec/features/form/page_routing_spec.rb
@@ -119,6 +119,16 @@ RSpec.describe "Form Page Routing" do
expect(find_field("lettings_log[startdate(2i)]").value).to eq(nil)
expect(find_field("lettings_log[startdate(1i)]").value).to eq(nil)
end
+
+ it "does not show see all related answers link if only 1 field has an error" do
+ visit("/lettings-logs/#{id}/tenancy-start-date")
+ fill_in("lettings_log[startdate(1i)]", with: "202")
+ fill_in("lettings_log[startdate(2i)]", with: "32")
+ fill_in("lettings_log[startdate(3i)]", with: "0")
+ click_button("Save and continue")
+
+ expect(page).not_to have_link("See all related answers")
+ end
end
end
@@ -262,4 +272,21 @@ RSpec.describe "Form Page Routing" do
end
end
end
+
+ describe "composite validations" do
+ context "when error is added to multiple fields" do
+ before do
+ lettings_log.update(needstype: 1, declaration: 1, ecstat1: 10, hhmemb: 2, net_income_known: 0, incfreq: 1, earnings: 1000)
+ end
+
+ it "does shows see all related answers link" do
+ visit("/lettings-logs/#{id}/income-amount")
+ fill_in("lettings-log-earnings-field", with: "100000")
+ click_button("Save and continue")
+
+ expect(page).to have_current_path("/lettings-logs/#{id}/income-amount")
+ expect(page).to have_button("See all related answers")
+ end
+ end
+ end
end
diff --git a/spec/requests/check_errors_controller_spec.rb b/spec/requests/check_errors_controller_spec.rb
new file mode 100644
index 000000000..c101e7959
--- /dev/null
+++ b/spec/requests/check_errors_controller_spec.rb
@@ -0,0 +1,455 @@
+require "rails_helper"
+
+RSpec.describe CheckErrorsController, type: :request do
+ let(:page) { Capybara::Node::Simple.new(response.body) }
+ let(:user) { create(:user, :data_coordinator) }
+ let(:lettings_log) { create(:lettings_log, :setup_completed, assigned_to: user) }
+ let(:sales_log) { create(:sales_log, :shared_ownership_setup_complete, assigned_to: user) }
+
+ describe "check errors page" do
+ context "when user is not signed in" do
+ it "redirects to sign in page for lettings" do
+ post "/lettings-logs/#{lettings_log.id}/net-income", params: {}
+ expect(response).to redirect_to("/account/sign-in")
+ end
+
+ it "redirects to sign in page for sales" do
+ post "/sales-logs/#{sales_log.id}/buyer-1-income", params: {}
+ expect(response).to redirect_to("/account/sign-in")
+ end
+ end
+
+ context "when the user is from different organisation" do
+ let(:other_user) { create(:user) }
+
+ before do
+ sign_in other_user
+ end
+
+ it "renders page not found for lettings" do
+ post "/lettings-logs/#{lettings_log.id}/net-income", params: {}
+ expect(response).to have_http_status(:not_found)
+ end
+
+ it "renders page not found for sales" do
+ post "/sales-logs/#{sales_log.id}/buyer-1-income", params: {}
+ expect(response).to have_http_status(:not_found)
+ end
+ end
+
+ context "when user is signed in" do
+ context "with multiple error fields and answered questions for lettings" do
+ let(:params) do
+ {
+ id: lettings_log.id,
+ lettings_log: {
+ page: "income_amount",
+ earnings: "100000",
+ incfreq: "1",
+ },
+ check_errors: "",
+ }
+ end
+
+ before do
+ lettings_log.update!(needstype: 1, declaration: 1, ecstat1: 10, hhmemb: 2, net_income_known: 0, incfreq: nil, earnings: nil)
+ sign_in user
+ post "/lettings-logs/#{lettings_log.id}/income-amount", params: params
+ end
+
+ it "displays correct clear links" do
+ expect(page).to have_selector("input[type=submit][value='Clear']", count: 2)
+ expect(page).to have_button("Clear all")
+ end
+ end
+
+ context "with multiple error fields and answered questions for sales" do
+ let(:params) do
+ {
+ id: sales_log.id,
+ sales_log: {
+ page: "buyer_1_income",
+ income1: "100000",
+ la: "E09000001",
+ ownershipsch: "1",
+ },
+ check_errors: "",
+ }
+ end
+
+ before do
+ sales_log.update!(income1: 1000, la: "E09000001")
+ sign_in user
+ post "/sales-logs/#{sales_log.id}/buyer-1-income", params: params
+ end
+
+ it "displays correct clear and change links" do
+ expect(page.all(:button, value: "Clear").count).to eq(2)
+ expect(page).to have_link("Change", count: 1)
+ expect(page).to have_button("Clear all")
+ end
+ end
+ end
+ end
+
+ describe "confirm clear answer page" do
+ context "when user is not signed in" do
+ it "redirects to sign in page for lettings" do
+ post "/lettings-logs/#{lettings_log.id}/confirm-clear-answer", params: {}
+ expect(response).to redirect_to("/account/sign-in")
+ end
+
+ it "redirects to sign in page for sales" do
+ post "/sales-logs/#{sales_log.id}/confirm-clear-answer", params: {}
+ expect(response).to redirect_to("/account/sign-in")
+ end
+ end
+
+ context "when the user is from different organisation" do
+ let(:other_user) { create(:user) }
+
+ before do
+ sign_in other_user
+ end
+
+ it "renders page not found for lettings" do
+ post "/lettings-logs/#{lettings_log.id}/confirm-clear-answer", params: {}
+ expect(response).to have_http_status(:not_found)
+ end
+
+ it "renders page not found for sales" do
+ post "/sales-logs/#{sales_log.id}/confirm-clear-answer", params: {}
+ expect(response).to have_http_status(:not_found)
+ end
+ end
+
+ context "when user is signed in" do
+ context "and clearing specific lettings question" do
+ let(:params) do
+ {
+ id: lettings_log.id,
+ lettings_log: {
+ earnings: "100000",
+ incfreq: "1",
+ hhmemb: "2",
+ page_id: "income_amount",
+ },
+ hhmemb: "",
+ }
+ end
+
+ before do
+ sign_in user
+ post "/lettings-logs/#{lettings_log.id}/confirm-clear-answer", params:
+ end
+
+ it "displays correct clear links" do
+ expect(page).to have_content("Are you sure you want to clear Number of household members?")
+ expect(page).to have_content("Dependent answers related to this question may also get cleared. You will not be able to undo this action.")
+ expect(page).to have_link("Cancel")
+ expect(page).to have_button("Confirm and continue")
+ end
+ end
+
+ context "and clearing specific sales question" do
+ let(:params) do
+ {
+ id: sales_log.id,
+ sales_log: {
+ income1: "100000",
+ la: "E09000001",
+ ownershipsch: "1",
+ page_id: "buyer_1_income",
+ },
+ income1: "",
+ }
+ end
+
+ before do
+ sign_in user
+ post "/sales-logs/#{sales_log.id}/confirm-clear-answer", params:
+ end
+
+ it "displays correct clear links" do
+ expect(page).to have_content("Are you sure you want to clear Buyer 1’s gross annual income?")
+ expect(page).to have_content("Dependent answers related to this question may also get cleared. You will not be able to undo this action.")
+ expect(page).to have_link("Cancel")
+ expect(page).to have_button("Confirm and continue")
+ end
+ end
+ end
+ end
+
+ describe "confirm clear all answers" do
+ context "when user is signed in" do
+ context "and clearing all lettings questions" do
+ let(:params) do
+ {
+ id: lettings_log.id,
+ clear_all: "Clear all",
+ lettings_log: {
+ earnings: "100000",
+ incfreq: "1",
+ hhmemb: "2",
+ page_id: "income_amount",
+ },
+ }
+ end
+
+ before do
+ sign_in user
+ post "/lettings-logs/#{lettings_log.id}/confirm-clear-answer", params:
+ end
+
+ it "displays correct clear links" do
+ expect(page).to have_content("Are you sure you want to clear all")
+ expect(page).to have_content("You've selected 5 answers to clear")
+ expect(page).to have_content("You will not be able to undo this action")
+ expect(page).to have_link("Cancel")
+ expect(page).to have_button("Confirm and continue")
+ end
+ end
+
+ context "and clearing all sales question" do
+ let(:params) do
+ {
+ id: sales_log.id,
+ clear_all: "Clear all",
+ sales_log: {
+ income1: "100000",
+ la: "E09000001",
+ ownershipsch: "1",
+ page_id: "buyer_1_income",
+ },
+ }
+ end
+
+ before do
+ sign_in user
+ post "/sales-logs/#{sales_log.id}/confirm-clear-answer", params:
+ end
+
+ it "displays correct clear links" do
+ expect(page).to have_content("Are you sure you want to clear all")
+ expect(page).to have_content("You've selected 3 answers to clear")
+ expect(page).to have_content("You will not be able to undo this action")
+ expect(page).to have_link("Cancel")
+ expect(page).to have_button("Confirm and continue")
+ end
+ end
+ end
+ end
+
+ describe "clear answer" do
+ context "when user is not signed in" do
+ it "redirects to sign in page for lettings" do
+ post "/lettings-logs/#{lettings_log.id}/income-amount", params: {}
+ expect(response).to redirect_to("/account/sign-in")
+ end
+
+ it "redirects to sign in page for sales" do
+ post "/sales-logs/#{sales_log.id}/buyer-1-income", params: {}
+ expect(response).to redirect_to("/account/sign-in")
+ end
+ end
+
+ context "when the user is from different organisation" do
+ let(:other_user) { create(:user) }
+
+ before do
+ sign_in other_user
+ end
+
+ it "renders page not found for lettings" do
+ post "/lettings-logs/#{lettings_log.id}/income-amount", params: {}
+ expect(response).to have_http_status(:not_found)
+ end
+
+ it "renders page not found for sales" do
+ post "/sales-logs/#{lettings_log.id}/buyer-1-income", params: {}
+ expect(response).to have_http_status(:not_found)
+ end
+ end
+
+ context "when user is signed in" do
+ context "and clearing specific lettings question" do
+ let(:params) do
+ {
+ id: lettings_log.id,
+ lettings_log: {
+ earnings: "100000",
+ incfreq: "1",
+ hhmemb: "2",
+ clear_question_ids: "hhmemb",
+ page: "income_amount",
+ },
+ check_errors: "",
+ }
+ end
+
+ before do
+ sign_in user
+ post "/lettings-logs/#{lettings_log.id}/income-amount", params:
+ end
+
+ it "displays correct clear links" do
+ expect(page).to have_content("Make sure these answers are correct")
+ expect(page).to have_content("You didn’t answer this question")
+ expect(page).to have_link("Answer")
+ expect(lettings_log.reload.earnings).to eq(nil)
+ end
+ end
+
+ context "and clearing specific sales question" do
+ let(:params) do
+ {
+ id: sales_log.id,
+ sales_log: {
+ income1: "100000",
+ la: "E09000001",
+ ownershipsch: "1",
+ clear_question_ids: "income1",
+ page: "buyer_1_income",
+ },
+ check_errors: "",
+ }
+ end
+
+ before do
+ sign_in user
+ post "/sales-logs/#{sales_log.id}/buyer-1-income", params:
+ end
+
+ it "displays correct clear links" do
+ expect(page).to have_content("Make sure these answers are correct")
+ expect(page).to have_content("You didn’t answer this question")
+ expect(page).to have_link("Answer")
+ expect(sales_log.reload.income1).to eq(nil)
+ end
+ end
+ end
+ end
+
+ describe "answer incomplete question" do
+ context "when user is signed in" do
+ context "and answering specific lettings question" do
+ let(:params) do
+ {
+ original_page_id: "household_members",
+ referrer: "check_errors",
+ related_question_ids: %w[hhmemb ecstat1 earnings],
+ lettings_log: {
+ page: "household_members",
+ hhmemb: "2",
+ },
+ }
+ end
+
+ before do
+ sign_in user
+ post "/lettings-logs/#{lettings_log.id}/household-members", params:
+ end
+
+ it "maintains original check_errors data in query params" do
+ follow_redirect!
+ expect(request.query_parameters["check_errors"]).to eq("true")
+ expect(request.query_parameters["related_question_ids"]).to eq(%w[hhmemb ecstat1 earnings])
+ expect(page).to have_content("You have successfully updated Number of household members")
+ expect(page).to have_link("Confirm and continue", href: "/lettings-logs/#{lettings_log.id}/household-members")
+ end
+ end
+
+ context "and answering specific sales question" do
+ let(:params) do
+ {
+ original_page_id: "buyer_1_income",
+ referrer: "check_errors",
+ related_question_ids: %w[income1 la ownershipsch],
+ sales_log: {
+ page: "buyer_1_income",
+ income1: "1000",
+ income1nk: "0",
+ },
+ }
+ end
+
+ before do
+ sign_in user
+ post "/sales-logs/#{sales_log.id}/buyer-1-income", params:
+ end
+
+ it "maintains original check_errors data in query params" do
+ follow_redirect!
+ expect(request.query_parameters["check_errors"]).to eq("true")
+ expect(request.query_parameters["related_question_ids"]).to eq(%w[income1 la ownershipsch])
+ expect(page).to have_content("You have successfully updated Buyer 1’s gross annual income known? and Buyer 1’s gross annual income")
+ expect(page).to have_link("Confirm and continue", href: "/sales-logs/#{sales_log.id}/buyer-1-income")
+ end
+ end
+ end
+ end
+
+ describe "clear all answers" do
+ context "when user is signed in" do
+ context "and clearing all lettings question" do
+ let(:params) do
+ {
+ id: lettings_log.id,
+ lettings_log: {
+ earnings: "100000",
+ incfreq: "1",
+ hhmemb: "2",
+ clear_question_ids: "earnings incfreq hhmemb",
+ page: "income_amount",
+ },
+ check_errors: "",
+ }
+ end
+
+ before do
+ sign_in user
+ post "/lettings-logs/#{lettings_log.id}/income-amount", params:
+ end
+
+ it "correctly clears the values" do
+ expect(page).to have_content("Make sure these answers are correct")
+ expect(page).to have_content("You didn’t answer this question")
+ expect(page.all(:button, value: "Clear").count).to eq(0)
+ expect(lettings_log.reload.earnings).to eq(nil)
+ expect(lettings_log.reload.incfreq).to eq(nil)
+ expect(lettings_log.reload.hhmemb).to eq(nil)
+ end
+ end
+
+ context "and clearing all sales question" do
+ let(:params) do
+ {
+ id: sales_log.id,
+ sales_log: {
+ income1: "100000",
+ la: "E09000001",
+ ownershipsch: "1",
+ clear_question_ids: "income1 la ownershipsch",
+ page: "buyer_1_income",
+ },
+ check_errors: "",
+ }
+ end
+
+ before do
+ sign_in user
+ post "/sales-logs/#{sales_log.id}/buyer-1-income", params:
+ end
+
+ it "displays correct clear links" do
+ expect(page).to have_content("Make sure these answers are correct")
+ expect(page).to have_content("You didn’t answer this question")
+ expect(page.all(:button, value: "Clear").count).to eq(0)
+ expect(sales_log.reload.income1).to eq(nil)
+ expect(sales_log.reload.la).to eq(nil)
+ expect(sales_log.reload.ownershipsch).not_to eq(nil)
+ end
+ end
+ end
+ end
+end