Browse Source

refactor: rename non_blank_fields_count to valid_field_numbers_count

pull/1588/head
Sam Seed 3 years ago
parent
commit
0f3e48f80c
  1. 2
      app/services/bulk_upload/lettings/validator.rb
  2. 2
      app/services/bulk_upload/lettings/year2023/csv_parser.rb

2
app/services/bulk_upload/lettings/validator.rb

@ -131,7 +131,7 @@ private
def validate_fields_count
return if halt_validations?
errors.add(:base, :wrong_field_count) if csv_parser.non_blank_fields_count != csv_parser.class::FIELDS
errors.add(:base, :wrong_field_count) if csv_parser.valid_field_numbers_count != csv_parser.class::FIELDS
end
def halt_validations!

2
app/services/bulk_upload/lettings/year2023/csv_parser.rb

@ -46,7 +46,7 @@ class BulkUpload::Lettings::Year2023::CsvParser
cols[field_numbers.find_index(field) + col_offset]
end
def non_blank_fields_count
def valid_field_numbers_count
field_numbers.count { |f| f != "field_blank" }
end

Loading…
Cancel
Save