From 0f2ae232d391f6155f008303e2cbc35a102b1c20 Mon Sep 17 00:00:00 2001 From: natdeanlewissoftwire Date: Fri, 10 Feb 2023 14:05:14 +0000 Subject: [PATCH] feat: conditional year behaviour and test --- .../form/sales/pages/about_staircase.rb | 10 +++- .../form/sales/pages/about_staircase_spec.rb | 20 ++++++- .../sales/questions/staircase_sale_spec.rb | 53 +++++++++++++++++++ 3 files changed, 79 insertions(+), 4 deletions(-) create mode 100644 spec/models/form/sales/questions/staircase_sale_spec.rb diff --git a/app/models/form/sales/pages/about_staircase.rb b/app/models/form/sales/pages/about_staircase.rb index 73ae5d342..2d1a17db4 100644 --- a/app/models/form/sales/pages/about_staircase.rb +++ b/app/models/form/sales/pages/about_staircase.rb @@ -12,7 +12,13 @@ class Form::Sales::Pages::AboutStaircase < ::Form::Page @questions ||= [ Form::Sales::Questions::StaircaseBought.new(nil, nil, self), Form::Sales::Questions::StaircaseOwned.new(nil, nil, self), - Form::Sales::Questions::StaircaseSale.new(nil, nil, self), - ] + staircase_sale_question, + ].compact + end + + def staircase_sale_question + if form.start_date.year >= 2023 + Form::Sales::Questions::StaircaseSale.new(nil, nil, self) + end end end diff --git a/spec/models/form/sales/pages/about_staircase_spec.rb b/spec/models/form/sales/pages/about_staircase_spec.rb index a2fba103e..3828f52e4 100644 --- a/spec/models/form/sales/pages/about_staircase_spec.rb +++ b/spec/models/form/sales/pages/about_staircase_spec.rb @@ -11,8 +11,24 @@ RSpec.describe Form::Sales::Pages::AboutStaircase, type: :model do expect(page.subsection).to eq(subsection) end - it "has correct questions" do - expect(page.questions.map(&:id)).to eq(%w[stairbought stairowned]) + describe "questions" do + let(:subsection) { instance_double(Form::Subsection, form: instance_double(Form, start_date:)) } + + context "when 2022" do + let(:start_date) { Time.utc(2022, 2, 8) } + + it "has correct questions" do + expect(page.questions.map(&:id)).to eq(%w[stairbought stairowned]) + end + end + + context "when 2023" do + let(:start_date) { Time.utc(2023, 2, 8) } + + it "has correct questions" do + expect(page.questions.map(&:id)).to eq(%w[stairbought stairowned staircasesale]) + end + end end it "has the correct id" do diff --git a/spec/models/form/sales/questions/staircase_sale_spec.rb b/spec/models/form/sales/questions/staircase_sale_spec.rb new file mode 100644 index 000000000..3114c8109 --- /dev/null +++ b/spec/models/form/sales/questions/staircase_sale_spec.rb @@ -0,0 +1,53 @@ +require "rails_helper" + +RSpec.describe Form::Sales::Questions::StaircaseSale, type: :model do + subject(:question) { described_class.new(question_id, question_definition, page) } + + let(:question_id) { nil } + let(:question_definition) { nil } + let(:page) { instance_double(Form::Page) } + + it "has correct page" do + expect(question.page).to eq(page) + end + + it "has the correct id" do + expect(question.id).to eq("staircasesale") + end + + it "has the correct header" do + expect(question.header).to eq("Is this transaction part of a back-to-back staircasing transaction to facilitate sale of the home on the open market?") + end + + it "has the correct check_answer_label" do + expect(question.check_answer_label).to eq("Part of a back-to-back staircasing transaction") + end + + it "has the correct type" do + expect(question.type).to eq("radio") + end + + it "has the correct type" do + expect(question.type).to eq("radio") + end + + it "is not marked as derived" do + expect(question.derived?).to be false + end + + it "has the correct answer_options" do + expect(question.answer_options).to eq({ + "1" => { "value" => "Yes" }, + "2" => { "value" => "No" }, + "3" => { "value" => "Don't know" }, + }) + end + + it "has correct conditional for" do + expect(question.conditional_for).to eq(nil) + end + + it "has the correct hint" do + expect(question.hint_text).to be_nil + end +end