From 0d583a67862e5882a9f9d1c272bbffaa64439839 Mon Sep 17 00:00:00 2001 From: Kat Date: Thu, 17 Aug 2023 15:35:17 +0100 Subject: [PATCH] Add old_form_id import task and service --- .../sales_logs_field_import_service.rb | 21 +++++++++++ lib/tasks/data_import_field.rake | 2 +- spec/lib/tasks/date_import_field_spec.rb | 21 +++++++++++ .../sales_logs_field_import_service_spec.rb | 37 +++++++++++++++++++ 4 files changed, 80 insertions(+), 1 deletion(-) diff --git a/app/services/imports/sales_logs_field_import_service.rb b/app/services/imports/sales_logs_field_import_service.rb index e677cc8a0..2a08a7ccf 100644 --- a/app/services/imports/sales_logs_field_import_service.rb +++ b/app/services/imports/sales_logs_field_import_service.rb @@ -6,6 +6,8 @@ module Imports import_from(folder, :update_creation_method) when "owning_organisation_id" import_from(folder, :update_owning_organisation_id) + when "old_form_id" + import_from(folder, :update_old_form_id) else raise "Updating #{field} is not supported by the field import service" end @@ -51,5 +53,24 @@ module Imports @logger.warn("sales log with old id #{old_id} not found") end end + + def update_old_form_id(xml_doc) + return unless meta_field_value(xml_doc, "form-name").include?("Sales") + + old_id = meta_field_value(xml_doc, "document-id") + record = SalesLog.find_by(old_id:) + + if record.present? + if record.old_form_id.present? + @logger.info("sales log #{record.id} has a value for old_form_id, skipping update") + else + old_form_id = safe_string_as_integer(xml_doc, "Form") + record.update!(old_form_id:) + @logger.info("sales log #{record.id}'s old_form_id value has been set to #{old_form_id}") + end + else + @logger.warn("sales log with old id #{old_id} not found") + end + end end end diff --git a/lib/tasks/data_import_field.rake b/lib/tasks/data_import_field.rake index d16ae752e..80e42399e 100644 --- a/lib/tasks/data_import_field.rake +++ b/lib/tasks/data_import_field.rake @@ -29,7 +29,7 @@ namespace :core do # We only allow a reduced list of known fields to be updatable case field - when "owning_organisation_id" + when "owning_organisation_id", "old_form_id" s3_service = Storage::S3Service.new(PlatformHelper.is_paas? ? Configuration::PaasConfigurationService.new : Configuration::EnvConfigurationService.new, ENV["IMPORT_PAAS_INSTANCE"]) archive_io = s3_service.get_file_io(path) archive_service = Storage::ArchiveService.new(archive_io) diff --git a/spec/lib/tasks/date_import_field_spec.rb b/spec/lib/tasks/date_import_field_spec.rb index cac433449..84de7cf87 100644 --- a/spec/lib/tasks/date_import_field_spec.rb +++ b/spec/lib/tasks/date_import_field_spec.rb @@ -160,6 +160,27 @@ describe "data_import_field imports" do end end + context "and we update the old_form_id field" do + let(:field) { "old_form_id" } + + it "updates the logs from the given XML file when the VCAP_SERVICES environment variable exists" do + expect(Storage::S3Service).to receive(:new).with(paas_config_service, instance_name) + expect(storage_service).to receive(:get_file_io).with("spec/fixtures/imports/sales_logs") + expect(Imports::SalesLogsFieldImportService).to receive(:new).with(archive_service) + expect(import_service).to receive(:update_field).with(field, "logs") + task.invoke(field, fixture_path) + end + + it "updates the logs from the given XML file when the VCAP_SERVICES environment variable does not exist" do + allow(ENV).to receive(:[]).with("VCAP_SERVICES") + expect(Storage::S3Service).to receive(:new).with(env_config_service, instance_name) + expect(storage_service).to receive(:get_file_io).with("spec/fixtures/imports/sales_logs") + expect(Imports::SalesLogsFieldImportService).to receive(:new).with(archive_service) + expect(import_service).to receive(:update_field).with(field, "logs") + task.invoke(field, fixture_path) + end + end + it "raises an exception if no parameters are provided" do expect { task.invoke }.to raise_error(/Usage/) end diff --git a/spec/services/imports/sales_logs_field_import_service_spec.rb b/spec/services/imports/sales_logs_field_import_service_spec.rb index 238e91359..f1ae6680c 100644 --- a/spec/services/imports/sales_logs_field_import_service_spec.rb +++ b/spec/services/imports/sales_logs_field_import_service_spec.rb @@ -110,4 +110,41 @@ RSpec.describe Imports::SalesLogsFieldImportService do end end end + + context "when updating old_form_id" do + let(:field) { "old_form_id" } + let(:sales_log_filename) { "shared_ownership_sales_log" } + + context "when the sales log has no offered value" do + let(:sales_log) { SalesLog.find_by(old_id: sales_log_filename) } + + before do + Imports::SalesLogsImportService.new(storage_service, logger).create_logs(fixture_directory) + sales_log_file.rewind + sales_log.update!(old_form_id: nil) + end + + it "updates the sales_log old_form_id value" do + expect(logger).to receive(:info).with("sales log #{sales_log.id}'s old_form_id value has been set to 300204") + expect { import_service.send(:update_field, field, remote_folder) } + .to(change { sales_log.reload.old_form_id }.from(nil).to(300_204)) + end + end + + context "when the sales log has a different offered value" do + let(:sales_log) { SalesLog.find_by(old_id: sales_log_filename) } + + before do + Imports::SalesLogsImportService.new(storage_service, logger).create_logs(fixture_directory) + sales_log_file.rewind + sales_log.update!(old_form_id: 123) + end + + it "does not update the sales_log old_form_id value" do + expect(logger).to receive(:info).with(/sales log \d+ has a value for old_form_id, skipping update/) + expect { import_service.send(:update_field, field, remote_folder) } + .not_to(change { sales_log.reload.old_form_id }) + end + end + end end