CLDC-4523: Use new feedback form link (#3390)

* feat: use new feedback form link and use shared ref

* refactor: linting

* refactor: linting

* feat: fix unfrozen time-dependent test

app/views/layouts/_feedback.html.erb

@@ -10,7 +10,7 @@
           </div>
         </div>
         <div class="gem-c-feedback__prompt-questions">
-          <a class="govuk-button gem-c-feedback__prompt-link" target="_blank" href="https://forms.office.com/e/thT1Vm7edm">
+          <a class="govuk-button gem-c-feedback__prompt-link" target="_blank" href="<%= I18n.t("feedback_form") %>">
             Give feedback (opens in a new tab)
           </a>
         </div>

config/locales/en.yml

@@ -31,7 +31,7 @@
 
 en:
   service_name: "Submit social housing lettings and sales data (CORE)"
-  feedback_form: "https://forms.office.com/e/thT1Vm7edm"
+  feedback_form: "https://forms.cloud.microsoft/Pages/ResponsePage.aspx?id=EGg0v32c3kOociSi7zmVqH_EURPnoZhLtbsnFZn-HdpUMEw2M04xWDc2QVNPNTBCMjQ1WDE0UU9HUi4u"
   organisation:
     created: "%{organisation} was created."
     updated: "Organisation details updated."

spec/requests/sales_logs_controller_spec.rb

@@ -915,6 +915,16 @@ RSpec.describe SalesLogsController, type: :request do
       end
 
       context "with sales logs from a closed previous collection period" do
+        # These examples need logs in the archived collection year,
+        # so we have to enforce we are in the crossover period
+        around do |example|
+          Timecop.freeze(current_collection_start_date) do
+            Singleton.__init__(FormHandler)
+            example.run
+          end
+          Singleton.__init__(FormHandler)
+        end
+
         let(:completed_sales_log) do
           FactoryBot.create(
             :sales_log,