Browse Source

Add remaining default soft validation values

pull/1384/head
Kat 3 years ago
parent
commit
0b9f57ac33
  1. 13
      app/services/imports/sales_logs_import_service.rb
  2. 101
      spec/services/imports/sales_logs_import_service_spec.rb

13
app/services/imports/sales_logs_import_service.rb

@ -142,6 +142,17 @@ module Imports
attributes["shared_ownership_deposit_value_check"] = 0
attributes["value_value_check"] = 0
attributes["savings_value_check"] = 0
attributes["income1_value_check"] = 0
attributes["deposit_value_check"] = 0
attributes["wheel_value_check"] = 0
attributes["retirement_value_check"] = 0
attributes["extrabor_value_check"] = 0
attributes["grant_value_check"] = 0
attributes["staircase_bought_value_check"] = 0
attributes["deposit_and_mortgage_value_check"] = 0
attributes["old_persons_shared_ownership_value_check"] = 0
attributes["income2_value_check"] = 0
attributes["monthly_charges_value_check"] = 0
# Sets the log creator
owner_id = meta_field_value(xml_doc, "owner-user-id").strip
@ -203,6 +214,7 @@ module Imports
def fields_not_present_in_softwire_data
%w[created_by
income1_value_check
income2_value_check
mortgage_value_check
savings_value_check
deposit_value_check
@ -402,7 +414,6 @@ module Imports
end
def monthly_charges(xml_doc, attributes)
safe_string_as_decimal(xml_doc, "Q29MonthlyCharges")
case attributes["ownershipsch"]
when 1
safe_string_as_decimal(xml_doc, "Q29MonthlyCharges")

101
spec/services/imports/sales_logs_import_service_spec.rb

@ -248,6 +248,24 @@ RSpec.describe Imports::SalesLogsImportService do
end
end
context "and the purchase price soft validation is triggered (income1_value_check, income2_value_check)" do
let(:sales_log_id) { "shared_ownership_sales_log" }
before do
sales_log_xml.at_xpath("//xmlns:Q2Person1Income").content = "20"
sales_log_xml.at_xpath("//xmlns:Q2Person2Income").content = "10"
sales_log_xml.at_xpath("//xmlns:P2Eco").content = "1"
sales_log_xml.at_xpath("//xmlns:joint").content = "1 Yes"
sales_log_xml.at_xpath("//xmlns:JointMore").content = "2 No"
end
it "completes the log" do
sales_log_service.send(:create_log, sales_log_xml)
sales_log = SalesLog.find_by(old_id: sales_log_id)
expect(sales_log.status).to eq("completed")
end
end
context "and the savings soft validation is triggered (savings_value_check)" do
let(:sales_log_id) { "shared_ownership_sales_log" }
@ -262,6 +280,89 @@ RSpec.describe Imports::SalesLogsImportService do
end
end
context "and the deposit soft validation is triggered (deposit_value_check)" do
let(:sales_log_id) { "shared_ownership_sales_log" }
before do
sales_log_xml.at_xpath("//xmlns:Q3Savings").content = "10"
end
it "completes the log" do
sales_log_service.send(:create_log, sales_log_xml)
sales_log = SalesLog.find_by(old_id: sales_log_id)
expect(sales_log.status).to eq("completed")
end
end
context "and the wheelchair soft validation is triggered (wheel_value_check)" do
let(:sales_log_id) { "shared_ownership_sales_log" }
before do
sales_log_xml.at_xpath("//xmlns:Q10Wheelchair").content = "1"
sales_log_xml.at_xpath("//xmlns:Disability").content = "2"
end
it "completes the log" do
sales_log_service.send(:create_log, sales_log_xml)
sales_log = SalesLog.find_by(old_id: sales_log_id)
expect(sales_log.status).to eq("completed")
end
end
context "and the retirement soft validation is triggered (retirement_value_check)" do
let(:sales_log_id) { "shared_ownership_sales_log" }
before do
sales_log_xml.at_xpath("//xmlns:P1Eco").content = "5"
end
it "completes the log" do
sales_log_service.send(:create_log, sales_log_xml)
sales_log = SalesLog.find_by(old_id: sales_log_id)
expect(sales_log.status).to eq("completed")
end
end
context "and the grant soft validation is triggered (grant_value_check)" do
let(:sales_log_id) { "discounted_ownership_sales_log" }
before do
sales_log_xml.at_xpath("//xmlns:Q32Reductions").content = "5000"
sales_log_xml.at_xpath("//xmlns:CALCMORT").content = "270000"
sales_log_xml.at_xpath("//xmlns:Q33Discount").content = ""
sales_log_xml.at_xpath("//xmlns:DerSaleType").content = "22"
end
it "completes the log" do
sales_log_service.send(:create_log, sales_log_xml)
sales_log = SalesLog.find_by(old_id: sales_log_id)
expect(sales_log.status).to eq("completed")
end
end
context "and the stairbought soft validation is triggered (staircase_bought_value_check)" do
let(:sales_log_id) { "shared_ownership_sales_log" }
before do
sales_log_xml.at_xpath("//xmlns:PercentBought").content = "51"
sales_log_xml.at_xpath("//xmlns:PercentOwns").content = "81"
sales_log_xml.at_xpath("//xmlns:Q17aStaircase").content = "1"
sales_log_xml.at_xpath("//xmlns:Q17Resale").content = ""
sales_log_xml.at_xpath("//xmlns:EXDAY").content = ""
sales_log_xml.at_xpath("//xmlns:EXMONTH").content = ""
sales_log_xml.at_xpath("//xmlns:EXYEAR").content = ""
sales_log_xml.at_xpath("//xmlns:HODAY").content = ""
sales_log_xml.at_xpath("//xmlns:HOMONTH").content = ""
sales_log_xml.at_xpath("//xmlns:HOYEAR").content = ""
end
it "completes the log" do
sales_log_service.send(:create_log, sales_log_xml)
sales_log = SalesLog.find_by(old_id: sales_log_id)
expect(sales_log.status).to eq("completed")
end
end
context "when inferring default answers for completed sales logs" do
context "when the armedforcesspouse is not answered" do
let(:sales_log_id) { "discounted_ownership_sales_log" }

Loading…
Cancel
Save