From 082cbf925af2718fe473faca8958bf89f6eef360 Mon Sep 17 00:00:00 2001 From: Phil Lee Date: Fri, 12 May 2023 13:20:45 +0100 Subject: [PATCH] refactor nil guard --- app/controllers/lettings_logs_controller.rb | 2 +- app/controllers/sales_logs_controller.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/lettings_logs_controller.rb b/app/controllers/lettings_logs_controller.rb index 6b1d4a531..ebaf9e64c 100644 --- a/app/controllers/lettings_logs_controller.rb +++ b/app/controllers/lettings_logs_controller.rb @@ -118,7 +118,7 @@ private end def redirect_if_bulk_upload_resolved - if @bulk_upload && @bulk_upload.lettings? && @bulk_upload.lettings_logs.in_progress.count.zero? + if @bulk_upload&.lettings? && @bulk_upload.lettings_logs.in_progress.count.zero? redirect_to resume_bulk_upload_lettings_result_path(@bulk_upload) end end diff --git a/app/controllers/sales_logs_controller.rb b/app/controllers/sales_logs_controller.rb index ecaa7e01a..246d61b8c 100644 --- a/app/controllers/sales_logs_controller.rb +++ b/app/controllers/sales_logs_controller.rb @@ -70,7 +70,7 @@ private end def redirect_if_bulk_upload_resolved - if @bulk_upload && @bulk_upload.sales? && @bulk_upload.sales_logs.in_progress.count.zero? + if @bulk_upload&.sales? && @bulk_upload.sales_logs.in_progress.count.zero? redirect_to resume_bulk_upload_sales_result_path(@bulk_upload) end end