Browse Source

remove BU min col check from sales

pull/1621/head
Phil Lee 3 years ago
parent
commit
0820096819
  1. 9
      app/services/bulk_upload/sales/validator.rb
  2. 1
      app/services/bulk_upload/sales/year2022/csv_parser.rb
  3. 1
      app/services/bulk_upload/sales/year2023/csv_parser.rb
  4. 12
      spec/services/bulk_upload/sales/validator_spec.rb

9
app/services/bulk_upload/sales/validator.rb

@ -4,7 +4,6 @@ class BulkUpload::Sales::Validator
attr_reader :bulk_upload, :path attr_reader :bulk_upload, :path
validate :validate_file_not_empty validate :validate_file_not_empty
validate :validate_min_columns
validate :validate_max_columns validate :validate_max_columns
def initialize(bulk_upload:, path:) def initialize(bulk_upload:, path:)
@ -106,14 +105,6 @@ private
end end
end end
def validate_min_columns
return if halt_validations?
column_count = rows.map(&:size).min
errors.add(:base, :under_min_column_count) if column_count < csv_parser.class::MIN_COLUMNS
end
def validate_max_columns def validate_max_columns
return if halt_validations? return if halt_validations?

1
app/services/bulk_upload/sales/year2022/csv_parser.rb

@ -1,7 +1,6 @@
require "csv" require "csv"
class BulkUpload::Sales::Year2022::CsvParser class BulkUpload::Sales::Year2022::CsvParser
MIN_COLUMNS = 125
MAX_COLUMNS = 126 MAX_COLUMNS = 126
attr_reader :path attr_reader :path

1
app/services/bulk_upload/sales/year2023/csv_parser.rb

@ -1,7 +1,6 @@
require "csv" require "csv"
class BulkUpload::Sales::Year2023::CsvParser class BulkUpload::Sales::Year2023::CsvParser
MIN_COLUMNS = 135
MAX_COLUMNS = 142 MAX_COLUMNS = 142
attr_reader :path attr_reader :path

12
spec/services/bulk_upload/sales/validator_spec.rb

@ -16,18 +16,6 @@ RSpec.describe BulkUpload::Sales::Validator do
end end
end end
context "when file has too few columns" do
before do
file.write("a," * 112)
file.write("\n")
file.rewind
end
it "is not valid" do
expect(validator).not_to be_valid
end
end
context "when file has too many columns" do context "when file has too many columns" do
before do before do
file.write((%w[a] * 127).join(",")) file.write((%w[a] * 127).join(","))

Loading…
Cancel
Save