baarkerlounger
/
submit-social-housing-lettings-and-sales-data
mirror of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

tests

pull/1776/head
Kat 3 years ago
parent
f180eeb96e
commit
07a22dd8b1
4 changed files with 24 additions and 23 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 22
      spec/models/lettings_log_spec.rb
  2. 11
      spec/models/sales_log_spec.rb
  3. 6
      spec/requests/duplicate_logs_controller_spec.rb
  4. 8
      spec/requests/form_controller_spec.rb

22
spec/models/lettings_log_spec.rb
Unescape View File

@ -3090,7 +3090,7 @@ RSpec.describe LettingsLog do
end end
context "when there is a log with nil values for tenancycode" do context "when there is a log with nil values for tenancycode" do
let!(:tenancycode_not_given) { create(:lettings_log, :duplicate, tenancycode: nil) } let!(:tenancycode_not_given) { create(:lettings_log, :duplicate, tenancycode: nil, owning_organisation: organisation) }
it "returns the log as a duplicate if tenancy code is nil" do it "returns the log as a duplicate if tenancy code is nil" do
log.update!(tenancycode: nil) log.update!(tenancycode: nil)
@ -3100,7 +3100,7 @@ RSpec.describe LettingsLog do
end end
context "when there is a log with age1 not known" do context "when there is a log with age1 not known" do
let!(:age1_not_known) { create(:lettings_log, :duplicate, age1_known: 1, age1: nil) } let!(:age1_not_known) { create(:lettings_log, :duplicate, age1_known: 1, age1: nil, owning_organisation: organisation) }
it "returns the log as a duplicate if age1 is not known" do it "returns the log as a duplicate if age1 is not known" do
log.update!(age1_known: 1, age1: nil) log.update!(age1_known: 1, age1: nil)
@ -3113,8 +3113,8 @@ RSpec.describe LettingsLog do
let(:scheme) { create(:scheme) } let(:scheme) { create(:scheme) }
let(:location) { create(:location, scheme:) } let(:location) { create(:location, scheme:) }
let(:location_2) { create(:location, scheme:) } let(:location_2) { create(:location, scheme:) }
let!(:supported_housing_log) { create(:lettings_log, :duplicate, needstype: 2, location:, scheme:) } let!(:supported_housing_log) { create(:lettings_log, :duplicate, needstype: 2, location:, scheme:, owning_organisation: organisation) }
let!(:duplicate_supported_housing_log) { create(:lettings_log, :duplicate, needstype: 2, location:, scheme:) } let!(:duplicate_supported_housing_log) { create(:lettings_log, :duplicate, needstype: 2, location:, scheme:, owning_organisation: organisation) }
it "returns the log as a duplicate" do it "returns the log as a duplicate" do
expect(duplicate_sets.count).to eq(2) expect(duplicate_sets.count).to eq(2)
@ -3129,8 +3129,8 @@ RSpec.describe LettingsLog do
end end
it "does not compare tcharge if there are no household charges" do it "does not compare tcharge if there are no household charges" do
supported_housing_log.update!(household_charge: 1, supcharg: nil, brent: nil, scharge: nil, pscharge: nil, tcharge: nil) supported_housing_log.update!(household_charge: 1, supcharg: nil, brent: nil, scharge: nil, pscharge: nil, tcharge: nil, owning_organisation: organisation)
duplicate_supported_housing_log.update!(household_charge: 1, supcharg: nil, brent: nil, scharge: nil, pscharge: nil, tcharge: nil) duplicate_supported_housing_log.update!(household_charge: 1, supcharg: nil, brent: nil, scharge: nil, pscharge: nil, tcharge: nil, owning_organisation: organisation)
expect(duplicate_sets.count).to eq(2) expect(duplicate_sets.count).to eq(2)
expect(duplicate_sets.first).to contain_exactly(log.id, duplicate_log.id) expect(duplicate_sets.first).to contain_exactly(log.id, duplicate_log.id)
expect(duplicate_sets.second).to contain_exactly(supported_housing_log.id, duplicate_supported_housing_log.id) expect(duplicate_sets.second).to contain_exactly(supported_housing_log.id, duplicate_supported_housing_log.id)
@ -3138,7 +3138,7 @@ RSpec.describe LettingsLog do
it "does not return logs not associated with the user if user is given" do it "does not return logs not associated with the user if user is given" do
user = create(:user) user = create(:user)
supported_housing_log.update!(created_by: user, managing_organisation: user.organisation) supported_housing_log.update!(created_by: user, owning_organisation: user.organisation)
duplicate_supported_housing_log.update!(owning_organisation: user.organisation) duplicate_supported_housing_log.update!(owning_organisation: user.organisation)
duplicate_sets = described_class.duplicate_sets(user.id) duplicate_sets = described_class.duplicate_sets(user.id)
expect(duplicate_sets.count).to eq(1) expect(duplicate_sets.count).to eq(1)
@ -3146,16 +3146,16 @@ RSpec.describe LettingsLog do
end end
it "compares chcharge if it's a carehome" do it "compares chcharge if it's a carehome" do
supported_housing_log.update!(is_carehome: 1, chcharge: 100, supcharg: nil, brent: nil, scharge: nil, pscharge: nil, tcharge: nil) supported_housing_log.update!(is_carehome: 1, chcharge: 100, supcharg: nil, brent: nil, scharge: nil, pscharge: nil, tcharge: nil, owning_organisation: organisation)
duplicate_supported_housing_log.update!(is_carehome: 1, chcharge: 100, supcharg: nil, brent: nil, scharge: nil, pscharge: nil, tcharge: nil) duplicate_supported_housing_log.update!(is_carehome: 1, chcharge: 100, supcharg: nil, brent: nil, scharge: nil, pscharge: nil, tcharge: nil, owning_organisation: organisation)
expect(duplicate_sets.count).to eq(2) expect(duplicate_sets.count).to eq(2)
expect(duplicate_sets.first).to contain_exactly(log.id, duplicate_log.id) expect(duplicate_sets.first).to contain_exactly(log.id, duplicate_log.id)
expect(duplicate_sets.second).to contain_exactly(supported_housing_log.id, duplicate_supported_housing_log.id) expect(duplicate_sets.second).to contain_exactly(supported_housing_log.id, duplicate_supported_housing_log.id)
end end
it "does not return a duplicate if carehome charge is not given" do it "does not return a duplicate if carehome charge is not given" do
supported_housing_log.update!(is_carehome: 1, chcharge: nil, supcharg: nil, brent: nil, scharge: nil, pscharge: nil, tcharge: nil) supported_housing_log.update!(is_carehome: 1, chcharge: nil, supcharg: nil, brent: nil, scharge: nil, pscharge: nil, tcharge: nil, owning_organisation: organisation)
duplicate_supported_housing_log.update!(is_carehome: 1, chcharge: nil, supcharg: nil, brent: nil, scharge: nil, pscharge: nil, tcharge: nil) duplicate_supported_housing_log.update!(is_carehome: 1, chcharge: nil, supcharg: nil, brent: nil, scharge: nil, pscharge: nil, tcharge: nil, owning_organisation: organisation)
expect(duplicate_sets.count).to eq(1) expect(duplicate_sets.count).to eq(1)
expect(duplicate_sets.first).to contain_exactly(log.id, duplicate_log.id) expect(duplicate_sets.first).to contain_exactly(log.id, duplicate_log.id)
end end

11
spec/models/sales_log_spec.rb
Unescape View File

@ -281,8 +281,8 @@ RSpec.describe SalesLog, type: :model do
context "when getting list of duplicate logs" do context "when getting list of duplicate logs" do
let(:organisation) { create(:organisation) } let(:organisation) { create(:organisation) }
let!(:log) { create(:sales_log, :duplicate) } let!(:log) { create(:sales_log, :duplicate, owning_organisation: organisation) }
let!(:duplicate_log) { create(:sales_log, :duplicate) } let!(:duplicate_log) { create(:sales_log, :duplicate, owning_organisation: organisation) }
let(:duplicate_sets) { described_class.duplicate_sets } let(:duplicate_sets) { described_class.duplicate_sets }
it "returns a list of duplicates in the same organisation" do it "returns a list of duplicates in the same organisation" do
@ -379,7 +379,7 @@ RSpec.describe SalesLog, type: :model do
end end
context "when there is a log with nil values for purchid" do context "when there is a log with nil values for purchid" do
let!(:purchid_not_given) { create(:sales_log, :duplicate, purchid: nil) } let!(:purchid_not_given) { create(:sales_log, :duplicate, purchid: nil, owning_organisation: organisation) }
it "returns the log as a duplicate if tenancy code is nil" do it "returns the log as a duplicate if tenancy code is nil" do
log.update!(purchid: nil) log.update!(purchid: nil)
@ -389,7 +389,7 @@ RSpec.describe SalesLog, type: :model do
end end
context "when there is a log with age1 not known" do context "when there is a log with age1 not known" do
let!(:age1_not_known) { create(:sales_log, :duplicate, age1_known: 1, age1: nil) } let!(:age1_not_known) { create(:sales_log, :duplicate, age1_known: 1, age1: nil, owning_organisation: organisation) }
it "returns the log as a duplicate if age1 is not known" do it "returns the log as a duplicate if age1 is not known" do
log.update!(age1_known: 1, age1: nil) log.update!(age1_known: 1, age1: nil)
@ -399,7 +399,7 @@ RSpec.describe SalesLog, type: :model do
end end
context "when there is a log with age1 prefers not to say" do context "when there is a log with age1 prefers not to say" do
let!(:age1_prefers_not_to_say) { create(:sales_log, :duplicate, age1_known: 2, age1: nil) } let!(:age1_prefers_not_to_say) { create(:sales_log, :duplicate, age1_known: 2, age1: nil, owning_organisation: organisation) }
it "returns the log as a duplicate if age1 is prefers not to say" do it "returns the log as a duplicate if age1 is prefers not to say" do
log.update!(age1_known: 2, age1: nil) log.update!(age1_known: 2, age1: nil)
@ -428,6 +428,7 @@ RSpec.describe SalesLog, type: :model do
end end
it "does not return logs not associated with the given user" do it "does not return logs not associated with the given user" do
duplicate_log.update!(owning_organisation: user.organisation)
duplicate_sets = described_class.duplicate_sets(user.id) duplicate_sets = described_class.duplicate_sets(user.id)
expect(duplicate_sets.count).to eq(1) expect(duplicate_sets.count).to eq(1)
expect(duplicate_sets.first).to contain_exactly(log.id, duplicate_log.id) expect(duplicate_sets.first).to contain_exactly(log.id, duplicate_log.id)

6
spec/requests/duplicate_logs_controller_spec.rb
Unescape View File

@ -380,9 +380,9 @@ RSpec.describe DuplicateLogsController, type: :request do
end end
it "shows links for each set of duplciates" do it "shows links for each set of duplciates" do
expect(page).to have_link("Review logs", href: lettings_log_duplicate_logs_path(1)) expect(page).to have_link("Review logs", href: lettings_log_duplicate_logs_path(1, original_log_id: 1))
expect(page).to have_link("Review logs", href: lettings_log_duplicate_logs_path(3)) expect(page).to have_link("Review logs", href: lettings_log_duplicate_logs_path(3, original_log_id: 3))
expect(page).to have_link("Review logs", href: sales_log_duplicate_logs_path(11)) expect(page).to have_link("Review logs", href: sales_log_duplicate_logs_path(11, original_log_id: 11))
end end
end end
end end

8
spec/requests/form_controller_spec.rb
Unescape View File

@ -797,7 +797,7 @@ RSpec.describe FormController, type: :request do
end end
it "redirects back to the duplicates page for remaining duplicates" do it "redirects back to the duplicates page for remaining duplicates" do
expect(response).to have_http_status(:ok) expect(response).to redirect_to("/lettings-logs/#{lettings_log.id}/duplicate-logs?original_log_id=#{lettings_log.id}")
end end
end end
end end
@ -805,13 +805,13 @@ RSpec.describe FormController, type: :request do
context "when the sales question was accessed from a duplicate logs screen" do context "when the sales question was accessed from a duplicate logs screen" do
let(:sales_log) { create(:sales_log, :duplicate, created_by: user) } let(:sales_log) { create(:sales_log, :duplicate, created_by: user) }
let(:duplicate_log) { create(:sales_log, :duplicate, created_by: user) } let(:duplicate_log) { create(:sales_log, :duplicate, created_by: user) }
let(:referrer) { "/sales-logs/#{sales_log.id}/buyer-1-age?referrer=duplicate_logs&first_remaining_duplicate_id=#{duplicate_log.id}&original_log_id=#{sales_log.id}" } let(:referrer) { "/sales-logs/#{sales_log.id}/buyer-1-age?referrer=duplicate_logs&first_remaining_duplicate_id=#{duplicate_log.id}&original_log_id=#{sales_log.id}&referrer=duplicate_logs" }
let(:params) do let(:params) do
{ {
id: sales_log.id, id: sales_log.id,
sales_log: { sales_log: {
page: "buyer_1_age", page: "buyer_1_age",
age1: 20, age1: 29,
age1_known: 1, age1_known: 1,
}, },
} }
@ -838,7 +838,7 @@ RSpec.describe FormController, type: :request do
end end
it "redirects back to the duplicates page for remaining duplicates" do it "redirects back to the duplicates page for remaining duplicates" do
expect(response).to have_http_status(:ok) expect(response).to redirect_to("/sales-logs/#{sales_log.id}/duplicate-logs?original_log_id=#{sales_log.id}")
end end
end end
end end

Write Preview
Loading…
Cancel
Save